A few questions
- why does type enum uses starknet keccak? and not Pedersen or Poseidon.
- ‘StarknetDomain’ instead of ‘StarkNetDomain’ no ?
- Defining a json schema might be better here to specify the constraints a little more. We have done that for the sign-in-with-starknet proposal and probably could be utilized here
- Could we use the byte array type coming in the next release to remove the 31 character limit for strings? Probably a major impediment for any adoption for off chain signing.